Skip to content

ci: use uv overrides to make sure tokenizers install from <=0.23.0 under subs#13767

Merged
sayakpaul merged 3 commits into
mainfrom
uv-overrides
May 21, 2026
Merged

ci: use uv overrides to make sure tokenizers install from <=0.23.0 under subs#13767
sayakpaul merged 3 commits into
mainfrom
uv-overrides

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

@github-actions github-actions Bot added CI size/M PR with diff < 200 LOC labels May 19, 2026
@sayakpaul
Copy link
Copy Markdown
Member Author

Failing tests are unrelated.

Cc: @hanouticelina @Wauplin could you review the PR and see if the prerelease substitution (typically done during CI testing for HFH releases) would comply?

@Wauplin
Copy link
Copy Markdown
Collaborator

Wauplin commented May 19, 2026

we can check on next release this week yes 👍 thanks for looking into it

@sayakpaul
Copy link
Copy Markdown
Member Author

I think I can check if the substitution of the HFH CI bot has any disruptive effect on this PR itself. If you could share what the installation would be to substitute, it would be helpful.

@sayakpaul sayakpaul requested a review from DN6 May 19, 2026 15:42
@sayakpaul sayakpaul marked this pull request as ready for review May 19, 2026 15:42
Wauplin added a commit that referenced this pull request May 21, 2026
Combines UV_OVERRIDE approach for tokenizers pinning (from PR #13767)
with --prerelease=allow flags (from ci-test branch).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR for the 1.16.0rc0 prerelease and it seems to work fine!

Got 2 failures but the tests did ran which is the goal of this PR (before it was stopping before the tests, at the install step)

FAILED tests/pipelines/z_image/test_z_image_img2img.py::ZImageImg2ImgPipelineFastTests::test_pipeline_with_accelerator_device_map - AssertionError: np.float32(nan) not less than 0.0005
E               AssertionError: False is not true : No param should be on 'meta' device.
tests/lora/utils.py:420: AssertionError
cat: reports/tests_models_lora_peft_main_failures_short.txt: No such file or directory

I'm therefore approving this PR which should help seamlessly testing hfh prereleases on diffusers in the future! ✔️

@sayakpaul
Copy link
Copy Markdown
Member Author

Thanks a lot sir! Those failures are transient and unrelated.

@sayakpaul sayakpaul merged commit 216e245 into main May 21, 2026
14 of 16 checks passed
@sayakpaul sayakpaul deleted the uv-overrides branch May 21, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/M PR with diff < 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants